AgentSkillsCN

receiving-code-review

在收到代码审查反馈时使用——在落实建议之前,尤其是当反馈显得不够清晰时。

SKILL.md
--- frontmatter
name: receiving-code-review
description: Use when receiving code review feedback -- before implementing suggestions, especially when feedback seems unclear

Receiving Code Review

Overview

Code review requires technical evaluation, not emotional performance.

Core principle: Verify before implementing. Ask before assuming. Technical correctness over social comfort.

The Response Pattern

code
WHEN receiving code review feedback:

1. READ: Complete feedback without reacting
2. UNDERSTAND: Restate requirement in own words (or ask)
3. VERIFY: Check against codebase reality
4. EVALUATE: Technically sound for THIS codebase?
5. RESPOND: Technical acknowledgment or reasoned pushback
6. IMPLEMENT: One item at a time, test each

Forbidden Responses

NEVER:

  • "You're absolutely right!"
  • "Great point!" / "Excellent feedback!"
  • "Let me implement that now" (before verification)

INSTEAD:

  • Restate the technical requirement
  • Ask clarifying questions
  • Push back with reasoning if wrong
  • Just start working (actions > words)

Handling Unclear Feedback

If ANY item is unclear: STOP. Do not implement anything yet. Ask for clarification on unclear items.

Items may be related. Partial understanding = wrong implementation.

YAGNI Check

If reviewer suggests "implementing properly":

  • Check actual usage in codebase
  • If unused: "This isn't called. Remove it (YAGNI)?"
  • If used: implement properly

Implementation Order

For multi-item feedback:

  1. Clarify anything unclear FIRST
  2. Blocking issues (breaks, security)
  3. Simple fixes (typos, imports)
  4. Complex fixes (refactoring, logic)
  5. Test each fix individually
  6. Verify no regressions

When to Push Back

Push back when:

  • Suggestion breaks existing functionality
  • Reviewer lacks full context
  • Violates YAGNI
  • Technically incorrect for this stack
  • Conflicts with prior architectural decisions

How: Use technical reasoning, not defensiveness. Reference working tests/code.

Acknowledging Correct Feedback

code
✅ "Fixed. [Brief description of what changed]"
✅ "Good catch - [specific issue]. Fixed in [location]."
✅ [Just fix it and show in the code]

❌ "You're absolutely right!"
❌ "Thanks for catching that!"
❌ ANY gratitude expression

Actions speak. Just fix it.

Common Mistakes

MistakeFix
Performative agreementState requirement or just act
Blind implementationVerify against codebase first
Batch without testingOne at a time, test each
Assuming reviewer is rightCheck if breaks things
Avoiding pushbackTechnical correctness > comfort