AgentSkillsCN

Security Review

安全评审

SKILL.md

Security Review

Purpose

Review Electron security, IPC isolation, preload bridge safety, and input validation. Prevent common Electron security vulnerabilities in Cooper.

When to Use

  • •Any change to src/preload/preload.ts
  • •New IPC channels or handlers in src/main/
  • •Changes involving user input, file system access, or shell execution
  • •Authentication or credential handling (Copilot SDK auth)

When NOT to Use

  • •Pure UI styling changes
  • •Documentation-only changes

Activation Rules

Step 1: Electron Security Checklist

RuleCheckSeverity
No nodeIntegration: truewebPreferences in main.ts🔴 Critical
No contextIsolation: falsewebPreferences in main.ts🔴 Critical
No remote moduleAnywhere in codebase🔴 Critical
No Node.js globals in renderersrc/renderer/ files🔴 Critical
All IPC goes through preloadNo direct ipcRenderer in renderer🟡 High
Input validation on IPC handlersipcMain.handle() callbacks🟡 High
No shell injectionchild_process / PTY usage🔴 Critical
No path traversalFile system operations🟡 High

Step 2: IPC Security Review

For each IPC channel:

  • •Validate inputs: Check types and bounds on main process side
  • •Minimize exposure: Only expose what renderer needs
  • •Namespace properly: Use copilot.*, git.*, voice.*, system.*, mcp.* prefixes

Step 3: Copilot SDK Security

  • •Token handling: Never expose tokens to renderer process
  • •Session data: Sanitize before sending to renderer
  • •Tool execution: Validate tool names and arguments before execution
  • •File operations: Validate paths, prevent directory traversal

Step 4: PTY/Terminal Security

  • •Shell commands: Never construct shell commands from user input without validation
  • •Working directory: Validate path exists and is within expected bounds
  • •Environment variables: Don't leak secrets through env

Cooper-Specific Patterns

Safe IPC exposure (preload.ts):

typescript
// ✅ Good: namespaced, typed, minimal surface
copilot: {
  sendMessage: (sessionId: string, message: string) =>
    ipcRenderer.invoke('copilot:send-message', sessionId, message),
}

// ❌ Bad: raw IPC access exposed
ipcRenderer: ipcRenderer  // NEVER DO THIS

Safe input validation (main.ts):

typescript
ipcMain.handle('system:open-path', async (_, path: string) => {
  // ✅ Validate before acting
  if (!path || typeof path !== 'string') throw new Error('Invalid path');
  const resolved = resolve(path);
  if (!resolved.startsWith(allowedBase)) throw new Error('Path not allowed');
  // proceed...
});

Success Criteria

  • •No Electron security rules violated
  • •All IPC inputs validated
  • •No Node.js globals leaked to renderer
  • •No secrets in code or logs

Related Skills